Dev 26.6 3#130
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates platform routing initialization for the desktop binary and significantly revises the GitHub Actions build/release workflow to expand the build matrix and standardize artifact packaging.
Changes:
- Removes the Windows-specific routing implementation and broadens the fallback routing file to build on Windows (
!linux). - Refactors the CI build matrix (per-target runners/artifact names) and adds workflow dispatch + concurrency controls.
- Updates toolchain setup (Go/Python/Xcode/Android NDK) and reworks artifact packaging/upload + release zipping.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
desktop_bin/route_windows.go |
Removes Windows-specific TUN address/route configuration logic. |
desktop_bin/route_other.go |
Expands non-Linux routing stub to include Windows builds (now a no-op on Windows). |
.github/workflows/build.yml |
Overhauls CI build matrix and artifact/release flow; updates action versions and toolchain setup. |
Comments suppressed due to low confidence (1)
desktop_bin/route_other.go:5
route_windows.gowas removed androute_other.gois now built for Windows (//go:build !linux). SinceinitIpRoutein this file is a no-op that always returns nil, Windows builds will now silently skip TUN address/route setup, which is a major behavioral change and can lead to hard-to-diagnose connectivity issues. Consider either restoring a Windows-specificinitIpRouteimplementation or making the Windows path fail explicitly (or be gated by config) rather than silently succeeding.
//go:build !linux
package main
func initIpRoute(_ string, _ int, _ bool) error {
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.